Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster - add support for the azure_policy property in the addon_profile block #4498

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

grahamhayes
Copy link
Contributor

Signed-off-by: Graham Hayes gr@ham.ie

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @grahamhayes. Thanks for opening this PR. These changes look good and are just missing a few minor things that I've called out below. I'm still waiting to be opted in to this preview but we can merge after these changes are in and I can run the tests

azurerm/data_source_kubernetes_cluster.go Outdated Show resolved Hide resolved
azurerm/data_source_kubernetes_cluster.go Outdated Show resolved Hide resolved
azurerm/resource_arm_kubernetes_cluster.go Show resolved Hide resolved
azurerm/resource_arm_kubernetes_cluster.go Show resolved Hide resolved
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to Request Changes. Apologies for the confusion

Signed-off-by: Graham Hayes <gr@ham.ie>
@katbyte katbyte changed the title Add support for Azure Policy for AKS add on azurerm_kubernetes_cluster - add support for the azure_policy property in the addon_profile block Oct 8, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revisions @grahamhayes! LGTM now 🙂

@katbyte katbyte added this to the v1.36.0 milestone Oct 8, 2019
@katbyte katbyte merged commit d7e5508 into hashicorp:master Oct 8, 2019
katbyte added a commit that referenced this pull request Oct 8, 2019
@ghost
Copy link

ghost commented Oct 29, 2019

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 7, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants