Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/virtual_machine_data_disk_attachment: removing the identity block when making a delta update #4538

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

tombuildsstuff
Copy link
Contributor

This PR fixes #2485 by removing the "identity" block when doing a delta update with the body from a Get response (which is required when updating a VM)

Fixes #2485

@tombuildsstuff tombuildsstuff added bug service/disk-attachments Virtual Machine Disk Attachments labels Oct 7, 2019
@ghost ghost added the size/M label Oct 7, 2019
@tombuildsstuff
Copy link
Contributor Author

Ignoring one test failing because of Quota issues the tests otherwise look good:

Screenshot 2019-10-07 at 11 11 39

@tombuildsstuff tombuildsstuff requested a review from a team October 7, 2019 09:12
@tombuildsstuff tombuildsstuff added this to the v1.36.0 milestone Oct 7, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit e9c229c into master Oct 10, 2019
katbyte added a commit that referenced this pull request Oct 10, 2019
@tombuildsstuff tombuildsstuff deleted the b/vm-data-disk-identity branch October 10, 2019 06:29
@ghost
Copy link

ghost commented Oct 29, 2019

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 9, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug service/disk-attachments Virtual Machine Disk Attachments size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use virtual_machine_data_disk_attachment on a VM with azurerm_user_assigned_identity
2 participants