Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_frontdoor update custom_host to be optional, add redirect_configuration to documentation #4601

Merged
merged 2 commits into from
Oct 11, 2019

Conversation

naikajah
Copy link
Contributor

@naikajah naikajah commented Oct 11, 2019

As per the Azure FrontDoor console operations. CustomHost in the redirect configuration should be optional to preserve the host from the incoming request.

(fixes #4461)
(fixes #4562)

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naikajah Thanks for this PR. I added a fix for another issue in your PR, hope that is ok, but this LGTM! 🚀

@WodansSon WodansSon added this to the v1.36.0 milestone Oct 11, 2019
@WodansSon WodansSon changed the title CustomHost to be Optional in Redirect Configuration azurerm_frontdoor update custom_host to be optional, add redirect_configuration to documentation Oct 11, 2019
@WodansSon
Copy link
Collaborator

image

@WodansSon WodansSon merged commit 841ce3b into hashicorp:master Oct 11, 2019
@ghost
Copy link

ghost commented Oct 29, 2019

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 11, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 11, 2019
@naikajah naikajah deleted the rfrontdoor_redirect_config branch November 29, 2019 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants