Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: azurerm_private_link_endpoint: fixes subresource name validation #5118

Merged
merged 3 commits into from
Dec 10, 2019

Conversation

WodansSon
Copy link
Collaborator

(fixes #5110 )

@WodansSon WodansSon added this to the v1.39.0 milestone Dec 10, 2019
@ghost ghost added the size/S label Dec 10, 2019
@ghost ghost added size/M and removed size/S labels Dec 10, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor

Tests pass:

$ go test -v ./azurerm/internal/services/network/
=== RUN   TestParseNetworkSecurityGroup
--- PASS: TestParseNetworkSecurityGroup (0.00s)
    network_security_group_test.go:43: [DEBUG] Testing "Empty"
    network_security_group_test.go:43: [DEBUG] Testing "No Network Security Groups Segment"
    network_security_group_test.go:43: [DEBUG] Testing "No Network Security Groups Value"
    network_security_group_test.go:43: [DEBUG] Testing "Completed"
=== RUN   TestParsePointToSiteVPNGateway
--- PASS: TestParsePointToSiteVPNGateway (0.00s)
    point_to_site_vpn_gateway_test.go:43: [DEBUG] Testing "Empty"
    point_to_site_vpn_gateway_test.go:43: [DEBUG] Testing "No Point-to-Site VPN Gateways Segment"
    point_to_site_vpn_gateway_test.go:43: [DEBUG] Testing "No Point-to-Site VPN Gateways Value"
    point_to_site_vpn_gateway_test.go:43: [DEBUG] Testing "Completed"
=== RUN   TestValidatePrivateLinkSubResourceName
--- PASS: TestValidatePrivateLinkSubResourceName (0.00s)
    private_link_endpoint_test.go:61: [DEBUG] Testing "Empty Value"
    private_link_endpoint_test.go:61: [DEBUG] Testing "Whitespace"
    private_link_endpoint_test.go:61: [DEBUG] Testing "Sql Server"
    private_link_endpoint_test.go:61: [DEBUG] Testing "Sql Server All Stop"
    private_link_endpoint_test.go:61: [DEBUG] Testing "Blob Secondary"
    private_link_endpoint_test.go:61: [DEBUG] Testing "Blob Secondary Invalid"
    private_link_endpoint_test.go:61: [DEBUG] Testing "Blob Secondary Space"
    private_link_endpoint_test.go:61: [DEBUG] Testing "Minimum Value Valid"
    private_link_endpoint_test.go:61: [DEBUG] Testing "Minimum Value Invalid"
=== RUN   TestParseRouteTable
--- PASS: TestParseRouteTable (0.00s)
    route_table_test.go:43: [DEBUG] Testing "Empty"
    route_table_test.go:43: [DEBUG] Testing "No Route Table Segment"
    route_table_test.go:43: [DEBUG] Testing "No Route Table Value"
    route_table_test.go:43: [DEBUG] Testing "Completed"
=== RUN   TestParseVirtualHub
--- PASS: TestParseVirtualHub (0.00s)
    virtual_hub_test.go:43: [DEBUG] Testing "Empty"
    virtual_hub_test.go:43: [DEBUG] Testing "No Virtual Hubs Segment"
    virtual_hub_test.go:43: [DEBUG] Testing "No Virtual Hubs Value"
    virtual_hub_test.go:43: [DEBUG] Testing "Completed"
=== RUN   TestValidateVirtualHub
--- PASS: TestValidateVirtualHub (0.00s)
    virtual_hub_test.go:93: [DEBUG] Testing ""
    virtual_hub_test.go:93: [DEBUG] Testing "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/foo"
    virtual_hub_test.go:93: [DEBUG] Testing "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/foo/virtualHubs/"
    virtual_hub_test.go:93: [DEBUG] Testing "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/foo/virtualHubs/example"
=== RUN   TestParseVirtualWan
--- PASS: TestParseVirtualWan (0.00s)
    virtual_wan_test.go:43: [DEBUG] Testing "Empty"
    virtual_wan_test.go:43: [DEBUG] Testing "No Virtual Wans Segment"
    virtual_wan_test.go:43: [DEBUG] Testing "No Virtual Wans Value"
    virtual_wan_test.go:43: [DEBUG] Testing "Completed"
=== RUN   TestValidateVirtualWan
--- PASS: TestValidateVirtualWan (0.00s)
    virtual_wan_test.go:93: [DEBUG] Testing ""
    virtual_wan_test.go:93: [DEBUG] Testing "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/foo"
    virtual_wan_test.go:93: [DEBUG] Testing "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/foo/virtualWans/"
    virtual_wan_test.go:93: [DEBUG] Testing "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/foo/virtualWans/example"
=== RUN   TestParseVPNGateway
--- PASS: TestParseVPNGateway (0.00s)
    vpn_gateway_test.go:43: [DEBUG] Testing "Empty"
    vpn_gateway_test.go:43: [DEBUG] Testing "No VPN Gateways Segment"
    vpn_gateway_test.go:43: [DEBUG] Testing "No VPN Gateways Value"
    vpn_gateway_test.go:43: [DEBUG] Testing "Completed"
=== RUN   TestParseVpnServerConfiguration
--- PASS: TestParseVpnServerConfiguration (0.00s)
    vpn_server_configuration_test.go:43: [DEBUG] Testing "Empty"
    vpn_server_configuration_test.go:43: [DEBUG] Testing "No VPN Server Configurations Segment"
    vpn_server_configuration_test.go:43: [DEBUG] Testing "No VPN Server Configurations Value"
    vpn_server_configuration_test.go:43: [DEBUG] Testing "Completed"
=== RUN   TestValidateVpnServerConfiguration
--- PASS: TestValidateVpnServerConfiguration (0.00s)
    vpn_server_configuration_test.go:93: [DEBUG] Testing ""
    vpn_server_configuration_test.go:93: [DEBUG] Testing "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/foo"
    vpn_server_configuration_test.go:93: [DEBUG] Testing "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/foo/vpnServerConfigurations/"
    vpn_server_configuration_test.go:93: [DEBUG] Testing "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/foo/vpnServerConfigurations/example"
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/network	0.018s

@ghost
Copy link

ghost commented Dec 16, 2019

This has been released in version 1.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.39.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants