-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_storage_account - fix performance issue for accounts that don't support queues #5316
azurerm_storage_account - fix performance issue for accounts that don't support queues #5316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @magodo
Thanks for this PR - taking a look through besides one minor comment to work around bad API responses this otherwise LGTM 👍
Thanks!
`resp.Sku` is a nilable object here, so we'd need to nil-check this first: Co-Authored-By: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@magodo thanks for pushing those changes - I hope you don't mind but so that we can get this merged I've pushed a commit to resolve the linting issue :) |
This has been released in version 1.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.41.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Not all storage account supports queue. Without this condition, user with unsupported kind will suffer a block (for about 10min) while reading the resource.