azure_batch_pool - support for the network_configuration property (#4088)

[sergiupantiru]

No description provided.

[petems]

@sergiupantiru To my untrained eye this looks pretty good! Are you able to add docs to this as well?

[sergiupantiru]

Oups :) forgot about the docs. Will try to add some

[sergiupantiru]

Added documentation and changed some fields to be mandatory. A lot of documentation is from info in the UI so i hope it will do.

[katbyte]

Thank you for the pr @sergiupantiru!

I've given this an initial review and left some comments inline. Once they are addressed this should be good to merge!

[katbyte]

Thanks for those changes @sergiupantiru, looking really close now. I've left some minor comments inline that should be the last of them!

[katbyte]

Thanks for the changes @sergiupantiru! This LGTM now 👍

[ghost]

This has been released in version 1.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.42.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!