-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added functionality to update in place RBAC AAD Profile #5410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, just a couple minor comments outside of what to do about the alt client ID & Secret
azurerm/internal/services/containers/tests/resource_arm_kubernetes_cluster_auth_test.go
Show resolved
Hide resolved
azurerm/internal/services/containers/tests/resource_arm_kubernetes_cluster_auth_test.go
Show resolved
Hide resolved
azurerm/internal/services/containers/resource_arm_kubernetes_cluster.go
Outdated
Show resolved
Hide resolved
Also i think the docs will need to have force new removed? |
@jackofallops is this the code that will support setting an AD Administrator on an Azure PostgreSQL Server? https://docs.microsoft.com/en-us/azure/postgresql/howto-configure-sign-in-aad-authentication |
Hi @ringods - This change is to enable updating the AAD profile for RBAC in an AKS cluster without a rebuild of the cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This has been released in version 1.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.42.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
fixes #3779
Note: Needs additional CI Env Vars for
ARM_CLIENT_ID_ALT
andARM_CLIENT_SECRET_ALT
before merge or update test will fail.