Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: 'azurerm_function_app' #5642

Merged
merged 4 commits into from
Feb 7, 2020

Conversation

jackbatzner
Copy link
Contributor

@jackbatzner jackbatzner commented Feb 7, 2020

Create a new data source for the 'azurerm_function_app' resource.

--- PASS: TestAccDataSourceAzureRMFunctionApp_basic (167.36s)
--- PASS: TestAccDataSourceAzureRMFunctionApp_connectionStrings (185.55s)
--- PASS: TestAccDataSourceAzureRMFunctionApp_appSettings (232.43s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/web/tests 232.760s

@jackbatzner jackbatzner changed the title Data source function app New Data source: 'azurerm_function_app' Feb 7, 2020
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just made some minor changes to the docs. Thanks for working on this @Brunhil

@mbfrahry mbfrahry changed the title New Data source: 'azurerm_function_app' New Data Source: 'azurerm_function_app' Feb 7, 2020
@mbfrahry mbfrahry merged commit d74deed into hashicorp:master Feb 7, 2020
mbfrahry added a commit that referenced this pull request Feb 7, 2020
@jackbatzner jackbatzner deleted the data_source_function_app branch March 14, 2020 14:49
@ghost
Copy link

ghost commented Mar 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants