-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Data Source: azurerm_scheduler_job_collection
#990
Conversation
9a466e1
to
95f95ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments to address - but this otherwise LGTM providing the tests pass 👍
} | ||
|
||
d.SetId(*collection.ID) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we set the other fields here? e.g. location
, resource_group_name
, name
etc
|
||
* `max_job_count` - Sets the maximum number of jobs in the collection. | ||
|
||
* `max_recurrence_frequency` - The maximum frequency of recurrence. Possible values include: `Minute`, `Hour`, `Day`, `Week`, `Month` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should be able to remove the Possible values...
from this section - since these values will be being returned
|
||
* `tags` - A mapping of tags to assign to the resource. | ||
|
||
* `sku` - The Job Collection's pricing level's SKU. Possible values include: `Standard`, `Free`, `P10Premium`, `P20Premium`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should be able to remove the Possible values...
from this section - since these values will be being returned
page_title: "Azure Resource Manager: azurerm_scheduler_job_collection" | ||
sidebar_current: "docs-azurerm-datasource-scheduler_job_collection" | ||
description: |- | ||
Get information about the specified schelduer job collection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scheduler*
|
||
* `name` - (Required) Specifies the name of the Scheduler Job Collection. Changing this forces a new resource to be created. | ||
|
||
* `resource_group_name` - (Required) The name of the resource group in which to create the Scheduler Job Collection. Changing this forces a new resource to be created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not creating anything - so we can we change this to Specifies the name of the Resource Group in which the Scheduler Job Collection exists
|
||
The following arguments are supported: | ||
|
||
* `name` - (Required) Specifies the name of the Scheduler Job Collection. Changing this forces a new resource to be created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not creating anything - so we can we change this to Specifies the name of the Scheduler Job Collection
5977c3e
to
6ad99fc
Compare
azurerm_scheduler_job_collection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
No description provided.