Datasource for retrieving GCS service account #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danawillow
reviewed
Feb 21, 2018
There was a problem hiding this comment.
Looks good! One quick nitpick.
$ make testacc TEST=./google TESTARGS='-run=TestAccDataSourceGoogleStorageProjectServiceAccount_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccDataSourceGoogleStorageProjectServiceAccount_basic -timeout 120m
=== RUN TestAccDataSourceGoogleStorageProjectServiceAccount_basic
--- PASS: TestAccDataSourceGoogleStorageProjectServiceAccount_basic (2.01s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google 2.253s
| } | ||
|
|
||
| serviceAccount, err := config.clientStorage.Projects.ServiceAccount.Get(project).Do() | ||
| if err != nil { |
There was a problem hiding this comment.
This block here can be replaced with:
if err != nil {
return handleNotFoundError(err, d, "GCS service account not found")
}
There was a problem hiding this comment.
Should be all set now
|
Thanks @ishashchuk! |
chrisst
pushed a commit
to chrisst/terraform-provider-google
that referenced
this pull request
Nov 9, 2018
* Datasource for retrieving GCS service account * Removing duplicated argument * Gofmt post resolving conflicts * Addressing review comment
modular-magician
added a commit
to modular-magician/terraform-provider-google
that referenced
this pull request
Sep 27, 2019
Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing issue 1105