Datasource for Backend Services #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nat-henderson
approved these changes
Mar 12, 2018
| "github.com/hashicorp/terraform/terraform" | ||
| ) | ||
|
|
||
| func TestAccGoogleComputeBackendService_basic(t *testing.T) { |
There was a problem hiding this comment.
nit: please remove "Google" from test names? We're trying to do that as of recently.
There was a problem hiding this comment.
Thanks for the review @ndmckinley !
I replaced the "Google" with "DataSource" in the tests names,
since just removing this string would name-clash with the resource's own tests, I hope that's ok?
|
Tests pass - happy to merge once you make that quick change. |
Exposes existing `google_compute_backend_service` as data sources. This addresses hashicorp#149 . This allows, for instance, to collect a backend service's self_link and use it from an other workspace/tfstate, sharing most of the loadbalancers definition. ``` env GOOGLE_REGION=us-central1 make testacc TEST=./google TESTARGS='-run=TestAccDataSourceComputeBackendService_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./google -v -run=TestAccDataSourceComputeBackendService_ -timeout 120m === RUN TestAccDataSourceComputeBackendService_basic === PAUSE TestAccDataSourceComputeBackendService_basic === CONT TestAccDataSourceComputeBackendService_basic --- PASS: TestAccDataSourceComputeBackendService_basic (48.11s) PASS ok github.com/terraform-providers/terraform-provider-google/google 48.123s ```
bpineau
force-pushed
the
ds-compute-backend-service
branch
from
d3373a3 to
dca85ba
Compare
ashish-amarnath
pushed a commit
to ashish-amarnath/terraform-provider-google
that referenced
this pull request
Mar 20, 2018
Exposes existing `google_compute_backend_service` as data sources. This addresses hashicorp#149 . This allows, for instance, to collect a backend service's self_link and use it from an other workspace/tfstate, sharing most of the loadbalancers definition.
chrisst
pushed a commit
to chrisst/terraform-provider-google
that referenced
this pull request
Nov 9, 2018
Exposes existing `google_compute_backend_service` as data sources. This addresses hashicorp#149 . This allows, for instance, to collect a backend service's self_link and use it from an other workspace/tfstate, sharing most of the loadbalancers definition.
modular-magician
added a commit
to modular-magician/terraform-provider-google
that referenced
this pull request
Sep 27, 2019
Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes existing
google_compute_backend_serviceas data sources.This addresses #149 (except for
google_compute_region_backend_service,which is not covered here).
This allows, for instance, to collect a backend service's self_link and
use it from an other workspace/tfstate, sharing most of the
loadbalancers definition.