Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include object versions when deleting all objects in GCS bucket #1285

Merged
merged 2 commits into from
Apr 3, 2018

Conversation

matthewrj
Copy link
Contributor

This fixes a bug where force_destory fails to delete a GCS bucket when there are versioned objects in the bucket. This is caused by the force_destroy logic only deleting the current versions of objects and not all previous versions. This PR ensures all previous versions of objects are also deleted.

@rosbo
Copy link
Contributor

rosbo commented Apr 3, 2018

Can you add an acceptance test with the following 2 steps to prove the fix works and prevent regression?

Step 1: Creates a versioned bucket and add object A with content Z
Step 2: Update object A to content Y

The test tear down will delete the bucket. The test will pass if the bucket is successfully deleted and fail otherwise.

Thank you

@rosbo rosbo self-assigned this Apr 3, 2018
@matthewrj
Copy link
Contributor Author

Done

@rosbo
Copy link
Contributor

rosbo commented Apr 3, 2018

All tests are passing on the CI server. Merging. Thanks @matthewrj :)

@rosbo rosbo merged commit b80aad4 into hashicorp:master Apr 3, 2018
@rosbo rosbo self-requested a review April 3, 2018 20:21
@ghost
Copy link

ghost commented Nov 19, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost unassigned rosbo Nov 19, 2018
@ghost ghost locked and limited conversation to collaborators Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants