Add Timeouts for Disk Snapshots #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running tests now. |
nat-henderson
force-pushed
the
snapshot-timeouts
branch
from
c1c0bdd to
a8c8b3d
Compare
|
Tests pass. |
nat-henderson
changed the title
rosbo
approved these changes
Apr 10, 2018
nat-henderson
pushed a commit
that referenced
this pull request
Apr 10, 2018
This simply adds the specification for operation timeouts, and sets sane defaults. In testing against specific regions, creation of SQL databases would fluctuate between 7-14 minutes against us-east1. As such, a 15m creation threshold is recommended for this. Update and Delete operations will adhere to 10m timeouts. This follows a similar format as #1309.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1307.