Generate google_vpn_gateway using Magic Module #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosbo
reviewed
May 1, 2018
| Type: schema.TypeString, | ||
| Required: true, |
There was a problem hiding this comment.
Uh oh. I will fix this to make the network field required.
|
Acceptance tests are failling. Hang on. I will fix this tomorrow morning. |
modular-magician
force-pushed
the
codegen-pr-139
branch
from
fb52950 to
af7858c
Compare
|
Does that change make the tests pass? |
| if err != nil { | ||
| return fmt.Errorf("Error Waiting to Insert VPN Gateway %s into network %s: %s", name, network.Name, err) |
There was a problem hiding this comment.
This error is a lot better - I see that it'd be a pain to autogenerate it, but how close can we get?
modular-magician
force-pushed
the
codegen-pr-139
branch
from
af7858c to
47ac832
Compare
nat-henderson
approved these changes
May 1, 2018
chrisst
pushed a commit
to chrisst/terraform-provider-google
that referenced
this pull request
Nov 9, 2018
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonus features: Import & Configurable Timeouts
cc/ @rosbo