Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute_firewall: set source_ranges to Computed to avoid perpetual diff #147

Merged
merged 1 commit into from
Jun 22, 2017

Conversation

pmcatominey
Copy link

@pmcatominey pmcatominey commented Jun 21, 2017

If this is not set in Terraform, then the API defaults to 0.0.0.0/0,
Terraform would then attempt to remove that value and so on.

Fixes #108

TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccComputeFirewall_ -timeout 120m
?   	github.com/terraform-providers/terraform-provider-google	[no test files]
=== RUN   TestAccComputeFirewall_importBasic
--- PASS: TestAccComputeFirewall_importBasic (72.87s)
=== RUN   TestAccComputeFirewall_basic
--- PASS: TestAccComputeFirewall_basic (65.87s)
=== RUN   TestAccComputeFirewall_update
--- PASS: TestAccComputeFirewall_update (88.22s)
=== RUN   TestAccComputeFirewall_noSource
--- PASS: TestAccComputeFirewall_noSource (79.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	306.762s

If this is not set in Terraform, then the API defaults to 0.0.0.0/0,
Terraform would then attempt to remove that value and so on.
Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense to me, tests pass. 👍 Thanks @pmcatominey!

@paddycarver paddycarver merged commit 89431e9 into hashicorp:master Jun 22, 2017
pdecat pushed a commit to pdecat/terraform-provider-google that referenced this pull request Jun 29, 2017
compute_firewall: set source_ranges to Computed to avoid perpetual diff
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
Move the set project logic higher in the read method
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_compute_firewall doesn't converge without source_ranges
2 participants