Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for custom request headers in backend services #1537

Merged
merged 3 commits into from
May 29, 2018
Merged

Add support for custom request headers in backend services #1537

merged 3 commits into from
May 29, 2018

Conversation

danawillow
Copy link
Contributor

No description provided.

@danawillow danawillow requested a review from nat-henderson May 25, 2018 02:08
nat-henderson
nat-henderson approved these changes May 25, 2018
View reviewed changes
Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume all the things in here that change the regular API to the beta one are safe, because we learned recently that the beta api responds exactly the same way as the v1 api except as documented?

@danawillow
Copy link
Contributor Author

Yup!

@danawillow danawillow merged commit dc46348 into hashicorp:master May 29, 2018
@danawillow danawillow deleted the gclb-headers branch May 29, 2018 20:29
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
@danawillow
Add support for custom request headers in backend services (hashicorp…
61505de 
…#1537)

* revendor compute beta apis

* changes to subnetwork iam from api revendoring

* add support for custom request headers in backend services
@ghost
Copy link

ghost commented Nov 18, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nat-henderson nat-henderson nat-henderson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danawillow @nat-henderson