Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the perma-diff in storage bucket ACLs #1692

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

paddycarver
Copy link
Contributor

Add a CustomDiff function to storage bucket ACLs that will ignore a diff
if the config and state have the same role_entities, even if they're in
a different order.

Fixes #1525 and #892.

Add a CustomDiff function to storage bucket ACLs that will ignore a diff
if the config and state have the same role_entities, even if they're in
a different order.

Fixes #1525.
@tmshn
Copy link
Contributor

tmshn commented Jun 22, 2018

Oh Terraform has a option CustomizeDiff...! DiffSuppressFunc was all I know.
This looks better solution than #1525 🤓 👍

@paddycarver
Copy link
Contributor Author

It's a relatively new API. I actually like #1525 better as a solution, and would like to leave it open for merging as part of 2.0.0, but with backwards compatibility concerns, CustomizeDiff may be a better for-the-moment solution.

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so glad this worked! Kudos to @ndmckinley for the clever idea as well.

@ghost
Copy link

ghost commented Nov 16, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants