Autogenerate router resource. Also adds update support and a few new fields. #1723
Conversation
modular-magician
force-pushed
the
codegen-pr-325
branch
from
352a963 to
249ef77
Compare
| }, | ||
|
|
||
| "project": &schema.Schema{ | ||
| "description": { |
There was a problem hiding this comment.
Description is ForceNew.
There was a problem hiding this comment.
Oh, I should have put this in the PR description, I added update support :P
There was a problem hiding this comment.
Oh I did put it in the PR description! Good job, past Dana.
There was a problem hiding this comment.
Ah! Sorry about that.
| Elem: &schema.Resource{ | ||
| Schema: map[string]*schema.Schema{ | ||
|
|
||
| "asn": &schema.Schema{ | ||
| "asn": { | ||
| Type: schema.TypeInt, | ||
| Required: true, |
| Type: schema.TypeList, | ||
| Optional: true, |
There was a problem hiding this comment.
bgp is required/forcenew.
There was a problem hiding this comment.
Turns out it's not actually required! I'm not really sure why you wouldn't include it but the API totally lets you create a router with just a name and network (https://cloud.google.com/compute/docs/reference/rest/v1/routers/insert if you're curious)
| is CUSTOM and is advertised to all peers of the router. These IP | ||
| ranges will be advertised in addition to any specified groups. | ||
| Leave this field blank to advertise no custom IP ranges. Structure is documented below. | ||
| The `advertised_ip_ranges` block supports: |
There was a problem hiding this comment.
There are some issues with these autogenerated docs - this tab is one - but I think my change will resolve those. Probably fine to just rebase and regenerate.
modular-magician
force-pushed
the
codegen-pr-325
branch
from
249ef77 to
a295ad7
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
/cc @danawillow