Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate ProjectIDRegex variable #1878

Merged
merged 2 commits into from
Sep 11, 2018

Conversation

michaelharo
Copy link
Contributor

No description provided.

@danawillow
Copy link
Contributor

Looks like unit tests didn't pass for this, can you take a look?

@michaelharo
Copy link
Contributor Author

I don't have the time or background to work on this.

@ghost ghost added the size/s label Sep 11, 2018
@danawillow
Copy link
Contributor

@ndmckinley, assigning you as a reviewer since I made some changes. The docs definitely disagree with this regex, but I also can't be bothered to find a better one (and this comes from the autogenerated GCP client so it's at least somewhat consistent)

@nat-henderson
Copy link
Contributor

That works for me. Bummer when the client and docs disagree - did you file a bug or should I?

@danawillow
Copy link
Contributor

I haven't looked into whether it's a docs bug or a client library bug, I'm happy to let you do it :)

I know the docs are at least somewhat wrong because they don't include the domain-scoped project ids, but I'm not sure about long ids (and this regex also accepts ids which start with a number, which feels wrong to me but might be a necessary consequence of allowing domain-scoping )

@danawillow danawillow merged commit 24c9cc7 into hashicorp:master Sep 11, 2018
@ghost
Copy link

ghost commented Nov 16, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants