Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the sql ssl (client) cert resource #2290

Merged
merged 2 commits into from
Nov 14, 2018

Conversation

benjvi
Copy link
Contributor

@benjvi benjvi commented Oct 19, 2018

Was trying to connect to a SQL instance and felt myself in the need of this resource. I believe this also would complete #635 ?

@ghost ghost added the size/xl label Oct 19, 2018
@nat-henderson nat-henderson self-requested a review November 7, 2018 20:37
Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you so much. :) I'm running it through our CI system now.

SchemaVersion: 1,

Schema: map[string]*schema.Schema{
"instance": &schema.Schema{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a particular ordering of schema elements we like to maintain. First, all Required fields, then, all Optionals (including Optional / Computed), then all Computed. Within each group, we like to sort alphabetically.

@nat-henderson
Copy link
Contributor

Great, the tests pass. Go ahead and make that simple ordering change, and that'll work for me! :)

@benjvi
Copy link
Contributor Author

benjvi commented Nov 8, 2018

Cool! Just pushed the ordering changes

@nat-henderson
Copy link
Contributor

The merge process for this one is going to look a little goofy - sorry for the delay - the issue is to do with how we're generating most files in this repo. I'm trying to invent a process that will handle the complication and right now, I don't need you to do anything else. I hope I'll have this in today or tomorrow.

modular-magician pushed a commit to modular-magician/terraform-provider-google that referenced this pull request Nov 14, 2018
@nat-henderson nat-henderson merged commit ce974ee into hashicorp:2.0.0 Nov 14, 2018
nat-henderson pushed a commit that referenced this pull request Dec 4, 2018
* add the sql client cert resource

* correct schema ordering for sql ssl cert resource
nat-henderson pushed a commit that referenced this pull request Dec 5, 2018
* add the sql client cert resource

* correct schema ordering for sql ssl cert resource
nat-henderson pushed a commit that referenced this pull request Dec 6, 2018
* add the sql client cert resource

* correct schema ordering for sql ssl cert resource
nat-henderson pushed a commit that referenced this pull request Dec 13, 2018
* add the sql client cert resource

* correct schema ordering for sql ssl cert resource
nat-henderson pushed a commit that referenced this pull request Dec 21, 2018
* add the sql client cert resource

* correct schema ordering for sql ssl cert resource
nat-henderson pushed a commit that referenced this pull request Dec 21, 2018
* add the sql client cert resource

* correct schema ordering for sql ssl cert resource
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
Add the sql ssl (client) cert resource, sibling of TPG hashicorp#2290.
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
Add the sql ssl (client) cert resource, sibling of TPG hashicorp#2290.
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants