-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the sql ssl (client) cert resource #2290
Add the sql ssl (client) cert resource #2290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you so much. :) I'm running it through our CI system now.
google/resource_sql_ssl_cert.go
Outdated
SchemaVersion: 1, | ||
|
||
Schema: map[string]*schema.Schema{ | ||
"instance": &schema.Schema{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a particular ordering of schema elements we like to maintain. First, all Required
fields, then, all Optional
s (including Optional
/ Computed
), then all Computed
. Within each group, we like to sort alphabetically.
Great, the tests pass. Go ahead and make that simple ordering change, and that'll work for me! :) |
Cool! Just pushed the ordering changes |
The merge process for this one is going to look a little goofy - sorry for the delay - the issue is to do with how we're generating most files in this repo. I'm trying to invent a process that will handle the complication and right now, I don't need you to do anything else. I hope I'll have this in today or tomorrow. |
* add the sql client cert resource * correct schema ordering for sql ssl cert resource
* add the sql client cert resource * correct schema ordering for sql ssl cert resource
* add the sql client cert resource * correct schema ordering for sql ssl cert resource
* add the sql client cert resource * correct schema ordering for sql ssl cert resource
* add the sql client cert resource * correct schema ordering for sql ssl cert resource
* add the sql client cert resource * correct schema ordering for sql ssl cert resource
Add the sql ssl (client) cert resource, sibling of TPG hashicorp#2290.
Add the sql ssl (client) cert resource, sibling of TPG hashicorp#2290.
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Was trying to connect to a SQL instance and felt myself in the need of this resource. I believe this also would complete #635 ?