Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate convenience fields in google_compute_snapshot #2572

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

modular-magician
Copy link
Collaborator

Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks reasonable to me.

Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels approximately right - two not-sure-about-it points.

google/resource_compute_snapshot.go Show resolved Hide resolved
google/resource_compute_snapshot.go Show resolved Hide resolved
@rileykarson rileykarson merged commit df27012 into hashicorp:2.0.0 Dec 5, 2018
nat-henderson pushed a commit that referenced this pull request Dec 11, 2018
<!-- This change is generated by MagicModules. -->
/cc @rileykarson
nat-henderson pushed a commit that referenced this pull request Dec 13, 2018
<!-- This change is generated by MagicModules. -->
/cc @rileykarson
paddycarver pushed a commit that referenced this pull request Dec 14, 2018
<!-- This change is generated by MagicModules. -->
/cc @rileykarson
nat-henderson pushed a commit that referenced this pull request Dec 21, 2018
<!-- This change is generated by MagicModules. -->
/cc @rileykarson
nat-henderson pushed a commit that referenced this pull request Dec 21, 2018
<!-- This change is generated by MagicModules. -->
/cc @rileykarson
@ghost
Copy link

ghost commented Jan 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 5, 2019
@modular-magician modular-magician deleted the codegen-pr-987 branch November 16, 2024 21:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants