Add Beta support & Beta feature ip_version to google_compute_global_forwarding_rule #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosbo
suggested changes
Jul 31, 2017
| resource.TestStep{ | ||
| Config: testAccComputeGlobalForwardingRule_ipv6(fr, proxy1, proxy2, backend, hc, urlmap), | ||
| Check: resource.ComposeTestCheckFunc( | ||
| testAccCheckComputeBetaGlobalForwardingRuleExists( |
There was a problem hiding this comment.
Same comment as in #250, consider adding an assertion on the format of the address field to make sure an ipv6 address is used. Do the same for the ipv4 case to make sure an ipv4 address is used
There was a problem hiding this comment.
Checked IPV4 on the _basic case, IpVersion is "" for this resource by default, but that means IPV4.
rosbo
approved these changes
Aug 3, 2017
|
This was referenced Aug 4, 2017
z1nkum
pushed a commit
to z1nkum/terraform-provider-google
that referenced
this pull request
Aug 15, 2017
…orwarding_rule (hashicorp#265) * Add versioned Beta support to google_compute_global_forwarding_rule. * Add Beta support for ip_version in google_compute_global_forwarding_rule. * Temporary commit with compute_shared_operation.go changes. * Added a test to see if v1 GFR is still IPV4, moved to a TestCheckFunc * This API returns the original self links, but let's make sure we don't diff.
negz
pushed a commit
to negz/terraform-provider-google
that referenced
this pull request
Oct 17, 2017
…orwarding_rule (hashicorp#265) * Add versioned Beta support to google_compute_global_forwarding_rule. * Add Beta support for ip_version in google_compute_global_forwarding_rule. * Temporary commit with compute_shared_operation.go changes. * Added a test to see if v1 GFR is still IPV4, moved to a TestCheckFunc * This API returns the original self links, but let's make sure we don't diff.
chrisst
pushed a commit
to chrisst/terraform-provider-google
that referenced
this pull request
Nov 9, 2018
…orwarding_rule (hashicorp#265) * Add versioned Beta support to google_compute_global_forwarding_rule. * Add Beta support for ip_version in google_compute_global_forwarding_rule. * Temporary commit with compute_shared_operation.go changes. * Added a test to see if v1 GFR is still IPV4, moved to a TestCheckFunc * This API returns the original self links, but let's make sure we don't diff.
luis-silva
pushed a commit
to luis-silva/terraform-provider-google
that referenced
this pull request
May 21, 2019
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on #249 to merge, but otherwise able to be reviewed.
The third commit duplicates some code in #250. I'm either going to base it into the first commit if this merges first, or merge #250 first.
google_compute_global_forwarding_ruleto a versioned resource with Beta support.ip_versiontogoogle_compute_global_forwarding_ruleExplicitly setting
IPV4on av1resource forces a recreate as you're going from""toIPV4and this resource can't update; this is working as expected based on #185. We don't have enough information at refresh time to perform the read atv0beta.Part 2/2 of #245.
Related to #93