Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test that multiple nics work in google_compute_instance. #289

Merged

Conversation

rileykarson
Copy link
Collaborator

It looks like our code already supports multiple network_interface fields on google_compute_instance.
Let's document that the API accepts multiple interfaces, although it is a Beta feature.

Fixes #82

@rosbo
Copy link
Contributor

rosbo commented Aug 4, 2017

Good timing for this PR, it made me realized I introduced a bug in #290. I opened a PR (#294) to fix it.

@rileykarson rileykarson merged commit a4e1083 into hashicorp:master Aug 4, 2017
z1nkum pushed a commit to z1nkum/terraform-provider-google that referenced this pull request Aug 15, 2017
…corp#289)

* Add a test that multiple nics works in google_compute_instance.

* Add note that multiple nics is in Beta.
negz pushed a commit to negz/terraform-provider-google that referenced this pull request Oct 17, 2017
…corp#289)

* Add a test that multiple nics works in google_compute_instance.

* Add note that multiple nics is in Beta.
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
…corp#289)

* Add a test that multiple nics works in google_compute_instance.

* Add note that multiple nics is in Beta.
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform creating GCE vm doesn't support multi nic configuration.
2 participants