Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial autogeneration of Spanner instance in Terraform. #2892

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Initial autogeneration of Spanner instance in Terraform. #2892

merged 1 commit into from
Jan 22, 2019

Conversation

modular-magician
Copy link
Collaborator

@ghost ghost added the size/xl label Jan 17, 2019
@modular-magician modular-magician mentioned this pull request Jan 17, 2019
Merged
@ghost ghost added the documentation label Jan 17, 2019
rileykarson
rileykarson requested changes Jan 18, 2019
View reviewed changes
google/provider_spanner_gen.go Show resolved Hide resolved
google/resource_spanner_instance.go Show resolved Hide resolved
google/resource_spanner_instance.go
"labels": {
Type: schema.TypeMap,
Optional: true,
Elem: &schema.Schema{Type: schema.TypeString},
},

"project": {
"name": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ForceNew?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I think it managed to sneak out of this commit: GoogleCloudPlatform/magic-modules@e366604

google/resource_spanner_instance.go Outdated Show resolved Hide resolved
website/docs/r/spanner_instance.html.markdown Outdated Show resolved Hide resolved
website/docs/r/spanner_instance.html.markdown Show resolved Hide resolved
website/docs/r/spanner_instance.html.markdown Outdated Show resolved Hide resolved
website/docs/r/spanner_instance.html.markdown Show resolved Hide resolved
@modular-magician modular-magician force-pushed the codegen-pr-1266 branch 2 times, most recently from 33822c1 to b1f91d0 Compare January 18, 2019 23:26
rileykarson
rileykarson approved these changes Jan 19, 2019
View reviewed changes
Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented with one last thing that may get lost in how GitHub shows comments- GoogleCloudPlatform/magic-modules@e366604 didn't have a ForceNew change, so I suspect you wanted to make name ForceNew in that commit.

Everything else LGTM

@nat-henderson @modular-magician
Initial autogeneration of Spanner instance in Terraform.
d1757f7 
Signed-off-by: Modular Magician <magic-modules@google.com>
@nat-henderson nat-henderson merged commit 738bdb9 into hashicorp:master Jan 22, 2019
@ghost
Copy link

ghost commented Feb 22, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Feb 22, 2019
@modular-magician modular-magician deleted the codegen-pr-1266 branch November 16, 2024 20:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nat-henderson nat-henderson nat-henderson left review comments

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
documentation size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@modular-magician @nat-henderson @rileykarson