-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Beta support for egress/direction to google_compute_firewall. #306
Add Beta support for egress/direction to google_compute_firewall. #306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the documentation for this feature
Done. |
make testacc TESTARGS="-run TestAccComputeFirewall_" TEST="./google" |
…shicorp#306) * Add Beta support for direction to google_compute_firewall. * Added docs.
…shicorp#306) * Add Beta support for direction to google_compute_firewall. * Added docs.
…shicorp#306) * Add Beta support for direction to google_compute_firewall. * Added docs.
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
direction
,destination_ranges
togoogle_compute_firewall
Neither is updateable by the API yet.
direction
always has a value in the API even when a null is sent; we need to conditionally read it as a result. This contrastsip_version
in #250, #265, which only has one when set explicitly.Fixes #283.
Relates to #93.