Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Beta support for egress/direction to google_compute_firewall. #306

Merged
merged 2 commits into from
Aug 8, 2017

Conversation

rileykarson
Copy link
Collaborator

@rileykarson rileykarson commented Aug 7, 2017

  • Add support for the Beta fields direction, destination_ranges to google_compute_firewall

Neither is updateable by the API yet.

direction always has a value in the API even when a null is sent; we need to conditionally read it as a result. This contrasts ip_version in #250, #265, which only has one when set explicitly.

Fixes #283.
Relates to #93.

Copy link
Contributor

@rosbo rosbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the documentation for this feature

@rileykarson
Copy link
Collaborator Author

Done.

@rosbo
Copy link
Contributor

rosbo commented Aug 8, 2017

make testacc TESTARGS="-run TestAccComputeFirewall_" TEST="./google"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run TestAccComputeFirewall_ -timeout 120m
=== RUN TestAccComputeFirewall_importBasic
--- PASS: TestAccComputeFirewall_importBasic (67.91s)
=== RUN TestAccComputeFirewall_basic
--- PASS: TestAccComputeFirewall_basic (66.95s)
=== RUN TestAccComputeFirewall_update
--- PASS: TestAccComputeFirewall_update (74.69s)
=== RUN TestAccComputeFirewall_noSource
--- PASS: TestAccComputeFirewall_noSource (62.85s)
=== RUN TestAccComputeFirewall_denied
--- PASS: TestAccComputeFirewall_denied (64.61s)
=== RUN TestAccComputeFirewall_egress
--- PASS: TestAccComputeFirewall_egress (64.17s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google 401.311s

@rileykarson rileykarson merged commit 89ce4d9 into hashicorp:master Aug 8, 2017
z1nkum pushed a commit to z1nkum/terraform-provider-google that referenced this pull request Aug 15, 2017
…shicorp#306)

* Add Beta support for direction to google_compute_firewall.

* Added docs.
negz pushed a commit to negz/terraform-provider-google that referenced this pull request Oct 17, 2017
…shicorp#306)

* Add Beta support for direction to google_compute_firewall.

* Added docs.
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
…shicorp#306)

* Add Beta support for direction to google_compute_firewall.

* Added docs.
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for google_compute_firewall Beta egress feature
2 participants