Container cluster importable #391
Conversation
| @@ -742,3 +747,15 @@ func generateNodePoolName(prefix string, d *schema.ResourceData) (string, error) | |||
| return resource.UniqueId(), nil | |||
| } | |||
| } | |||
|
|
|||
| func resourceContainerClusterStateImporter(d *schema.ResourceData, meta interface{}) ([]*schema.ResourceData, error) { | |||
There was a problem hiding this comment.
Test test is failling:
--- FAIL: TestAccGoogleContainerCluster_import (275.85s)
testing.go:428: Step 1 error: Resource specified by ResourceName couldn't be found: google_container_cluster.np
The ID should be set to the name only. See the create method above (line 474).
There was a problem hiding this comment.
Ahh.. Should be fixed now :)
|
I fixed the import acceptance test and pushed the change to your branch to be able to merge this quickly. TF_ACC=1 go test ./google -v -run TestAccGoogleContainerCluster_import -timeout 120m
=== RUN TestAccGoogleContainerCluster_import
--- PASS: TestAccGoogleContainerCluster_import (266.89s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google 267.016s |
Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Fixes #165
I had to change resourceContainerClusterRead to use container.Network rather than d.Get("network"), otherwise it would set network = "" during import. Not sure why network was set this way before?