Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CPU Platform in google_container_node_pool #622

Merged
merged 3 commits into from
Oct 25, 2017

Conversation

davidquarles
Copy link
Contributor

@davidquarles davidquarles commented Oct 23, 2017

This targets #620:

  • Update container/v1 API (handled independently in Update container/v1 API #624)
  • Add support for master_authorized_networks in google_container_cluster

It's probably worth noting that this flag isn't supported in all zones, and the available CPU platforms differ across zones where it is supported. I followed the same convention used in the compute_instance resource, which doesn't do any validation that I can see, but I can add validation if it makes sense to do so.

$ make testacc TEST=./google TESTARGS='-run=TestAccContainerCluster'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccContainerCluster -timeout 120m
=== RUN   TestAccContainerCluster_import
=== RUN   TestAccContainerCluster_basic
=== RUN   TestAccContainerCluster_withTimeout
=== RUN   TestAccContainerCluster_withAddons
=== RUN   TestAccContainerCluster_withMasterAuth
=== RUN   TestAccContainerCluster_withAdditionalZones
=== RUN   TestAccContainerCluster_withLegacyAbac
=== RUN   TestAccContainerCluster_withVersion
=== RUN   TestAccContainerCluster_updateVersion
=== RUN   TestAccContainerCluster_withNodeConfig
=== RUN   TestAccContainerCluster_withNodeConfigScopeAlias
=== RUN   TestAccContainerCluster_network
=== RUN   TestAccContainerCluster_backend
=== RUN   TestAccContainerCluster_withLogging
=== RUN   TestAccContainerCluster_withMonitoring
=== RUN   TestAccContainerCluster_withNodePoolBasic
=== RUN   TestAccContainerCluster_withNodePoolResize
=== RUN   TestAccContainerCluster_withNodePoolAutoscaling
=== RUN   TestAccContainerCluster_withNodePoolNamePrefix
=== RUN   TestAccContainerCluster_withNodePoolMultiple
=== RUN   TestAccContainerCluster_withNodePoolConflictingNameFields
=== RUN   TestAccContainerCluster_withNodePoolNodeConfig
--- PASS: TestAccContainerCluster_withNodePoolNamePrefix (371.07s)
--- PASS: TestAccContainerCluster_withNodePoolConflictingNameFields (371.71s)
--- PASS: TestAccContainerCluster_withNodePoolNodeConfig (372.95s)
--- PASS: TestAccContainerCluster_import (373.02s)
--- PASS: TestAccContainerCluster_withNodePoolMultiple (373.48s)
--- PASS: TestAccContainerCluster_backend (378.48s)
--- PASS: TestAccContainerCluster_withNodePoolBasic (382.56s)
--- PASS: TestAccContainerCluster_withMonitoring (622.97s)
--- PASS: TestAccContainerCluster_withVersion (392.99s)
--- PASS: TestAccContainerCluster_withNodeConfigScopeAlias (410.53s)
--- PASS: TestAccContainerCluster_withNodeConfig (420.80s)
--- PASS: TestAccContainerCluster_network (466.25s)
--- PASS: TestAccContainerCluster_updateVersion (669.28s)
--- PASS: TestAccContainerCluster_withLegacyAbac (640.45s)
--- PASS: TestAccContainerCluster_withAddons (538.82s)
--- PASS: TestAccContainerCluster_withNodePoolAutoscaling (791.10s)
--- PASS: TestAccContainerCluster_withMasterAuth (379.33s)
--- PASS: TestAccContainerCluster_withTimeout (370.64s)
--- PASS: TestAccContainerCluster_withAdditionalZones (479.85s)
--- PASS: TestAccContainerCluster_basic (369.87s)
--- PASS: TestAccContainerCluster_withNodePoolResize (801.13s)
--- PASS: TestAccContainerCluster_withLogging (631.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	1643.361s
$ make testacc TEST=./google TESTARGS='-run=TestAccContainerNodePool'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccContainerNodePool -timeout 120m
=== RUN   TestAccContainerNodePool_basic
=== RUN   TestAccContainerNodePool_namePrefix
=== RUN   TestAccContainerNodePool_noName
=== RUN   TestAccContainerNodePool_withNodeConfig
=== RUN   TestAccContainerNodePool_withNodeConfigScopeAlias
=== RUN   TestAccContainerNodePool_autoscaling
=== RUN   TestAccContainerNodePool_resize
--- PASS: TestAccContainerNodePool_basic (584.13s)
--- PASS: TestAccContainerNodePool_namePrefix (591.89s)
--- PASS: TestAccContainerNodePool_noName (595.05s)
--- PASS: TestAccContainerNodePool_withNodeConfigScopeAlias (655.04s)
--- PASS: TestAccContainerNodePool_withNodeConfig (659.93s)
--- PASS: TestAccContainerNodePool_resize (969.98s)
--- PASS: TestAccContainerNodePool_autoscaling (1189.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	1189.802s

@davidquarles davidquarles changed the title add support for CPU Platform in google_container_node_pool Add support for CPU Platform in google_container_node_pool Oct 24, 2017
@danawillow
Copy link
Contributor

Thanks @davidquarles, looks good! I made a quick fix to some broken links I saw, since I figured that would be easier than a back-and-forth. hope you don't mind :)

@danawillow
Copy link
Contributor

(fyi cool github trick- if you put something like Fixes #620 in your description, then the issue will automatically be closed once the PR is merged!)

@davidquarles
Copy link
Contributor Author

Awesome. I don't mind at all, and I appreciate you reviewing / merging this so quickly!

chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
…rp#622)

* update container/v1 API

* add support for CPU Platform in `google_container_node_pool`

* fix broken links
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants