Relax diff on maintenance_policy.daily_maintenance_window.start_time #726
Conversation
If the maintenance window has been set outside of Terraform to a time with a single-digit hour (such as 1:00), and the terraform definition is set to the same hour but with a leading zero as per validation (i.e. 01:00), do not consider the time to be changed (as we currently don't support update on this property). Fixes hashicorp#719
google/utils_test.go
Outdated
| func TestRfc3339TimeDiffSuppress(t *testing.T) { | ||
| old := "2:00" | ||
| new := "02:00" | ||
| if rfc3339TimeDiffSuppress("time", old, new, nil) == false { |
There was a problem hiding this comment.
Add also a test case to make sure it doesn't suppress a diff for the following cases:
2:00 and 3:00
02:00 and 3:00
2:00 and 03:00
I suggest you use a table driven test approach like TestIpCidrRangeDiffSuppress in this file.
|
Added more test cases as requested. I've removed my assumption that the 'new' value will always have a two-digit hour, in case that validation restriction gets lifted (or used somewhere else where it's not enforced). |
|
Thanks Michael! |
michaelbannister
deleted the
maintenance-window-relax-time-format-diff
branch
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Fixes #719.
Add a DiffSuppressFunc to start_time.
I can't see if there's a useful way to test this in the unit test and I can't see how I'd trigger this condition through an acceptance test case. Ideas & advice welcome!