-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change authorized_networks to a Set #733
Conversation
}, | ||
}, | ||
}, | ||
Set: schema.HashResource(sqlDatabaseAuthorizedNetWorkSchemaElem), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually the default behavior, so you don't need this line (I'm fine either way if you want to leave it in to be explicit).
I do wonder whether it actually makes more sense to hash on something a bit more like a primary key, like the network value. Even though our update logic will be the same no matter which part of it changes, it's possible that someone could get confused if they see in a plan that the whole thing is changing rather than just the part of it they changed. What do you think?
--- PASS: TestAccGoogleSqlDatabaseInstance_settings_basic (40.81s)
--- PASS: TestAccGoogleSqlDatabaseInstance_importBasic (50.12s)
--- PASS: TestAccGoogleSqlDatabaseInstance_basic (59.57s)
--- PASS: TestAccGoogleSqlDatabaseInstance_authNets (73.12s)
--- PASS: TestAccGoogleSqlDatabaseInstance_multipleOperations (74.13s)
--- PASS: TestAccGoogleSqlDatabaseInstance_basic2 (60.89s)
--- PASS: TestAccGoogleSqlDatabaseInstance_settings_downgrade (45.03s)
--- PASS: TestAccGoogleSqlDatabaseInstance_settings_upgrade (65.79s)
--- PASS: TestAccGoogleSqlDatabaseInstance_diskspecs (377.40s)
--- PASS: TestAccGoogleSqlDatabaseInstance_basic3 (419.98s)
--- PASS: TestAccGoogleSqlDatabaseInstance_importBasic3 (398.40s)
--- PASS: TestAccGoogleSqlDatabaseInstance_maintenance (459.13s)
--- PASS: TestAccGoogleSqlDatabaseInstance_dontDeleteDefaultUserOnReplica (644.16s)
--- PASS: TestAccGoogleSqlDatabaseInstance_slave (951.12s) |
GitHub appears to have eaten @rosbo's comment but it said:
|
Looks like tests are failing in CI, can you take a look?
|
Although weirdly it looks like this didn't start failing until last night, so it might actually just be a coincidence. |
Looking into it |
I found the issue, there is an expiration time set in the test and the date is |
Fix is here: #754 |
Signed-off-by: Modular Magician <magic-modules@google.com>
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Fixes #547 without changing the behavior of the update method (old style behavior where it tried as hard as possible to preserve changes that happened outside of Terraform, see #564).