Add the "google_compute_global_address" datasource #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Acceptance result: TF_ACC=1 go test $(go list ./... | grep -v 'vendor') -v -run=TestAccDataSourceComputeGlobalAddress -timeout 120m
? github.com/terraform-providers/terraform-provider-google [no test files]
=== RUN TestAccDataSourceComputeGlobalAddress
--- PASS: TestAccDataSourceComputeGlobalAddress (26.33s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google 26.362s
testing: warning: no tests to run
PASS
ok github.com/terraform-providers/terraform-provider-google/scripts 0.028s [no tests to run] |
rosbo
suggested changes
Nov 17, 2017
| } | ||
| } | ||
|
|
||
| func testAccCheckDataSourceComputeGlobalAddressDestroy(resource_name string) resource.TestCheckFunc { |
There was a problem hiding this comment.
You should be able to get the same result by using this method instead: testAccCheckComputeGlobalAddressDestroy
There was a problem hiding this comment.
i've "fixup" the code
--- PASS: TestAccDnsRecordSet_basic (22.47s) |
chrisst
pushed a commit
to chrisst/terraform-provider-google
that referenced
this pull request
Nov 9, 2018
* Add the "compute_global_address" datasource * Add a basic test for the "compute_global_address" datasource * Include the "compute_global_address" in the provider * Add docs for the "compute_global_address" datasource
modular-magician
pushed a commit
to modular-magician/terraform-provider-google
that referenced
this pull request
Sep 27, 2019
Send external gateway interface id if empty
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #748. This PR will be useful for users that want to expose the public IP of their HTTP load balancers.