-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service account IAM support #840
Conversation
|
||
## Import | ||
|
||
IAM member imports use space-delimited identifiers; the resource in question, the role, and the member. This member resource can be imported using the `service_account_id`, role, and member e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it were me, maybe I'd collapse these three into one "code sample" section and put the explanations above? I know I didn't do that for the doc I wrote, but now seeing it I think that might be clearer. Not feeling strongly about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. What do you think? Do you think I should elaborate around the fact that role is only used for member/binding and member only for the member resource? Or does the example speak for itself.
I just personally ran into this, seems like it would solve my issue, and supports importing. |
Also, update example to stop using the deprecated field.
* Add service account iam resources * Add documentation * Add import functionality to iam resources * Add import documentation
Signed-off-by: Modular Magician <magic-modules@google.com>
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Fixes #819
When managing IAM roles, you can treat a service account either as a resource or as an identity. This resource is to add iam policy bindings to a service account resource.
Import tests written in the new way proposed in #778.