Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read compute instance boot disk initialization params from API #948

Merged
merged 5 commits into from
Jan 17, 2018
Merged

Read compute instance boot disk initialization params from API #948

merged 5 commits into from
Jan 17, 2018

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Jan 11, 2018

Fixes #87

Pros:

  • Fixes import.
  • Detect changes happening outside Terraform.

Cons:

  • If the image is specified in the config using the image family, then the image names for that family must include the family name in its own name (all official images do) otherwise the diff won't be properly suppress. The same limitation applies to the google_compute_disk image field.

@rosbo rosbo requested a review from danawillow January 11, 2018 21:22
@rosbo rosbo force-pushed the read-instance-disk-type branch from baf6ad2 to 069bde4 Compare January 12, 2018 00:05
danawillow
danawillow approved these changes Jan 17, 2018
View reviewed changes
Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you add something in the docs about the image family name restriction?

@rosbo
Copy link
Contributor Author

rosbo commented Jan 17, 2018

Added.

@rosbo rosbo merged commit 681cc72 into hashicorp:master Jan 17, 2018
@rosbo rosbo deleted the read-instance-disk-type branch January 17, 2018 21:23
@rosbo rosbo mentioned this pull request Jan 23, 2018
Closed
@rosbo rosbo mentioned this pull request Jan 30, 2018
Merged
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
@rosbo
Read compute instance boot disk initialization params from API (hashi…
49f2c29 
…corp#948)

* read boot disk initialization param from API

* make fmt

* Mark the initialize_params list as computed to support boot source

* Ensure private family test follow naming pattern

* Improve docs
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request Sep 27, 2019
@modular-magician
Require master_ipv4_cidr_block if enable_private_nodes is true (hashi…
10a6657 
…corp#948)

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danawillow danawillow danawillow approved these changes

Assignees

@danawillow danawillow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terraform refresh does not recognize disk-type change in real-world state
2 participants
@rosbo @danawillow