Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autoscaler - was unnecessarily forcing to a single metric #966

Merged

Conversation

nat-henderson
Copy link
Contributor

Multiple metrics are supported, as the new test proves. Also, we weren't successfully storing the right information about custom metrics on read... you can imagine why we didn't catch that since it's a little-used feature.

This fixes #38.

@nat-henderson nat-henderson requested a review from rosbo January 17, 2018 00:55
}
}
}
fmt.Printf("customMetrics: %s\n", customMetrics)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this debug line

@nat-henderson
Copy link
Contributor Author

nat-henderson commented Jan 17, 2018

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccComputeAutoscaler -timeout 120m
=== RUN   TestAccComputeAutoscaler_basic
=== RUN   TestAccComputeAutoscaler_update
=== RUN   TestAccComputeAutoscaler_multicondition
--- PASS: TestAccComputeAutoscaler_basic (69.14s)
--- PASS: TestAccComputeAutoscaler_multicondition (70.74s)
--- PASS: TestAccComputeAutoscaler_update (82.94s)
PASS
ok      github.com/terraform-providers/terraform-provider-google/google 82.948s

@nat-henderson
Copy link
Contributor Author

nat-henderson commented Jan 17, 2018

Oh, and since CI's still behind:

01:04 $ make
==> Checking that code complies with gofmt requirements...
go install

@nat-henderson nat-henderson merged commit 719bbb4 into hashicorp:master Jan 17, 2018
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request Sep 27, 2019
Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants