Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add app engine flex version #5882

Conversation

modular-magician
Copy link
Collaborator

Added flexible app version resource.

Fixes #5025

This uses the same API as google_app_engine_standard_app_version, but they have different schemas (some fields are flex-only, etc) so we have decided to split them into two different resources.

Release Note Template for Downstream PRs (will be copied)

appengine: added new resource `google_appengine_flexible_app_version"

Derived from GoogleCloudPlatform/magic-modules#3110

* added flexible app version

* add sweeper file for flexible_app_version

* sweeper changes, add website link, etc

* add exclude to inspec.yaml

* add exclude to ansible.yaml

* missed

* sweeper review comments

* add test, other changes

* update test to flask, ignore read on beta_settings for now

* add copyright to app.yaml

* rm django zip

* update after review comments

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 1647e8f into hashicorp:master Mar 11, 2020
slevenick added a commit that referenced this pull request Mar 18, 2020
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding support for app engine flexible app version
1 participant