Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for kubernetes_storage_class #22

Merged
merged 2 commits into from
Jul 18, 2017
Merged

Add support for kubernetes_storage_class #22

merged 2 commits into from
Jul 18, 2017

Conversation

radeksimko
Copy link
Member

Closes #4

Test results

$ make testacc TEST=./kubernetes TESTARGS='-run="(TestAccKubernetesPersistentVolumeClaim_|TestAccKubernetesStorageClass_)"'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./kubernetes -v -run="(TestAccKubernetesPersistentVolumeClaim_|TestAccKubernetesStorageClass_)" -timeout 120m
=== RUN   TestAccKubernetesPersistentVolumeClaim_basic
--- PASS: TestAccKubernetesPersistentVolumeClaim_basic (4.83s)
=== RUN   TestAccKubernetesPersistentVolumeClaim_importBasic
--- PASS: TestAccKubernetesPersistentVolumeClaim_importBasic (31.03s)
=== RUN   TestAccKubernetesPersistentVolumeClaim_volumeMatch
--- PASS: TestAccKubernetesPersistentVolumeClaim_volumeMatch (56.22s)
=== RUN   TestAccKubernetesPersistentVolumeClaim_volumeUpdate
--- PASS: TestAccKubernetesPersistentVolumeClaim_volumeUpdate (33.79s)
=== RUN   TestAccKubernetesPersistentVolumeClaim_storageClass
--- PASS: TestAccKubernetesPersistentVolumeClaim_storageClass (23.35s)
=== RUN   TestAccKubernetesStorageClass_basic
--- PASS: TestAccKubernetesStorageClass_basic (6.76s)
=== RUN   TestAccKubernetesStorageClass_importBasic
--- PASS: TestAccKubernetesStorageClass_importBasic (2.46s)
=== RUN   TestAccKubernetesStorageClass_generatedName
--- PASS: TestAccKubernetesStorageClass_generatedName (2.16s)
=== RUN   TestAccKubernetesStorageClass_importGeneratedName
--- PASS: TestAccKubernetesStorageClass_importGeneratedName (2.31s)
PASS
ok  	github.com/terraform-providers/terraform-provider-kubernetes/kubernetes	162.989s

@radeksimko radeksimko mentioned this pull request Jul 10, 2017
Merged
grubernaut
grubernaut approved these changes Jul 17, 2017
View reviewed changes
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@radeksimko radeksimko merged commit bbb3e4e into master Jul 18, 2017
@radeksimko radeksimko deleted the f-storage-class branch July 18, 2017 05:27
@ghost ghost locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grubernaut grubernaut grubernaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Kubernetes storage_class resource
2 participants
@radeksimko @grubernaut