Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape '/' in JSON Patch path correctly #40

Merged
merged 1 commit into from
Aug 4, 2017
Merged

Escape '/' in JSON Patch path correctly #40

merged 1 commit into from
Aug 4, 2017
+112 −3

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Aug 3, 2017 •
edited
Loading

This is to address the main part of #37 but I'm intentionally not closing it yet.

=== RUN   TestAccKubernetesNamespace_withSpecialCharacters
--- PASS: TestAccKubernetesNamespace_withSpecialCharacters (6.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-kubernetes/kubernetes	6.575s

There's another issue causing spurious diffs when internal annotations are specified which still needs addressing.

@radeksimko radeksimko added the bug label Aug 3, 2017
grubernaut
grubernaut approved these changes Aug 4, 2017
View reviewed changes
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice fix

@radeksimko radeksimko merged commit 98bee7c into master Aug 4, 2017
@radeksimko radeksimko deleted the b-escape-json-ptr branch August 4, 2017 14:49
This was referenced Aug 17, 2017
Merged
Closed
@sagikazarmark sagikazarmark mentioned this pull request Dec 2, 2017
Closed
@Phylu Phylu mentioned this pull request Feb 28, 2018
Closed
@tdmalone tdmalone mentioned this pull request Feb 22, 2019
Closed
@ghost ghost locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grubernaut grubernaut grubernaut approved these changes

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @grubernaut