Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the optional subject_key_id parameter. #31

Merged
merged 2 commits into from
Aug 16, 2019
Merged

Added the optional subject_key_id parameter. #31

merged 2 commits into from
Aug 16, 2019

Conversation

IvanovOleg
Copy link
Contributor

@IvanovOleg IvanovOleg commented Oct 25, 2018

Some software like Kubernetes requires the subject_key_id field included in the tls certificate.

@ghost ghost added the size/XS label Oct 25, 2018
IvanovOleg and others added 2 commits August 16, 2019 15:40
This provider doesn't reach out to any other systems, so we can safely run
all of the tests as normal unit tests. This allows them to be run in our
CI system.
@ghost ghost added documentation size/M and removed size/XS labels Aug 16, 2019
@apparentlymart
Copy link
Contributor

Hi @IvanovOleg! Sorry for the very slow response here.

A made some minor adjustments here:

  • I renamed the argument to set_subject_key_id because our usual naming convention is for boolean flags to be named as verb phrases describing what action true implies; subject_key_id would (under usual naming scheme) read as a way to specify the subject key ID directly in the configuration, rather than to generate it.
  • I added a test case for this.

With those two small changes in place, I'm going to merge this now. Thanks for working on this, and sorry again that we took so long to respond.

@apparentlymart apparentlymart merged commit 4dbc80c into hashicorp:master Aug 16, 2019
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants