Replies: 1 comment
-
I'm all for better code organization. This is one of those that will probably mean tweaking the API, it sounds like. But that's fine. As a side note, isotopicDepletion has 74.4% code coverage. Could be better, for sure, but not terrible: file 1, file2. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I have not thought about this critically, but during a PR review found myself asking why they are separate packages. They are both related to depletion and could likely be coalesced into a single depletion package. The isotopicDepletion package has no tests, which is also suspect (though I suppose there are tests in the parent directory, which is kind of odd). I think combining them and maybe doing some potential cleanup would help improve long term maintainability of both packages.
Beta Was this translation helpful? Give feedback.
All reactions