Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported parameters are silently ignored #23

Closed
Temikus opened this issue Dec 28, 2015 · 1 comment
Closed

Unsupported parameters are silently ignored #23

Temikus opened this issue Dec 28, 2015 · 1 comment

Comments

@Temikus
Copy link
Contributor

Temikus commented Dec 28, 2015

I think users should know when their parameters are not actually applied:

platforms:
  - name: debian-7
    driver_config:
      image_name: debian-7-wheezy-v20151104
      require_chef_omnibus: true
      public_key_path: '/Users/temikus/.ssh/id_rsa.pub'
      auto_restart: true
      tags: ["kitchen"]

λ bundle exec kitchen create
-----> Starting Kitchen (v1.4.2)
-----> Creating <default-debian-7>...
       GCE instance <default-debian-7-cff9e788-b3b3-49d3-a156-40e761981e4f> created.
.....       (server ready)
       [SSH] Established
       (ssh ready)
       Finished creating <default-debian-7> (0m45.41s).
-----> Kitchen is finished. (0m46.15s)
@cheeseplus
Copy link

Trying to chase down invalid options by checking everything is a losing battle when ultimately having a correct config and good error messages when misconfiguration causes it to explode is the best defense against this problem. Chasing it the other way never ends well and it'd be a lot of code / gold plating for something that ultimately will be a moving target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants