Escape bundler environment when shelling out to fix #190 #191
Conversation
| # @see Kitchen::ShellOut#run_command | ||
| def run_command(cmd, options = {}) | ||
| merged = { | ||
| :use_sudo => config[:use_sudo], :log_subject => name | ||
| }.merge(options) | ||
| super(cmd, merged) | ||
| if Object.const_defined?("Bundler") | ||
| Bundler.with_clean_env { super(cmd, merged) } |
There was a problem hiding this comment.
@ksubrama this actually isn't enough 😦
We need to reset RUBYLIB and RUBYOPT as well as GEM_PATH and GEM_HOME and GEM_ROOT. It's pretty sad.
There was a problem hiding this comment.
I terribly misunderstood how bundler (and bundle exec works). Bundler.with_clean_env is utterly useless in the subprocess because by the time it has exec-ed the underlying script, the "pristine" environment is long gone. PATH has been mangled and GEM_* has been reset. And ORIGINAL_GEM_PATH is anything but original.
You're right... this is very very sad :(
There was a problem hiding this comment.
@ksubrama do not feel bad. I have been misunderstood for like a billion years. It's super super sad 😦.
Basically you'll likely need to do something like launch with a non-Ruby process (we used Go for this in Vagrant) which doesn't mangle the env, copy all keys in the current env to a different key, and then iterates and restores them before shelling out.
|
Fixing this properly with a wrapper seemed too annoying. I've currently changed it to simply blow away as many bad environment variables as possible in the hopes that it'll pick up the correct vagrant launch it with a good enough environment. |
|
LGTM |
| %w[BUNDLE_BIN_PATH BUNDLE_GEMFILE GEM_HOME GEM_PATH GEM_ROOT RUBY_LIB | ||
| RUBY_OPT _ORIGINAL_GEM_PATH].each do |var| | ||
| env[var] = nil | ||
| end |
There was a problem hiding this comment.
Might add a test to ensure these get stripped
|
Just stumbled upon (looks like a similar attempt to solve this. just for inspiration :-)): |
|
👍 |
| @@ -0,0 +1,2 @@ | |||
| --color | |||
| -fd | |||
There was a problem hiding this comment.
For future reference, I usually also add --require spec_helper.rb so that you don't have to have that require at the top of every spec file, but that may just be my preference. Don't need to change the PR
Escape bundler environment when shelling out to fix #190
|
Excellent, beat me to the green button. Thanks all! |
No description provided.