Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to customize Parallels Vagrantfile #84

Merged
merged 2 commits into from
Nov 10, 2014

Conversation

jhx
Copy link
Contributor

@jhx jhx commented Mar 21, 2014

  • convert key from snake_case to dash-case (prevents ugly yaml using
    quoted keys)
  • the customize hash below should be considered as a default to allow one to
    close the vm window if Parallels Desktop is open

File: .kitchen.yml:

- name: parallels-vm
  driver:
    provider: parallels
    box: parallels/centos-65
    customize:
      on_window_close: keep-running

converts to file: .kitchen/kitchen-vagrant/<name>/Vagrantfile:

 c.vm.provider :parallels do |p|
   p.customize ["set", :id, "--on-window-close", "keep-running"]
 end

jhx added 2 commits March 20, 2014 19:21
- convert key from snake_case to dash-case (prevents ugly yaml using
  quoted keys)
- the customize hash below should be considered as a default to allow one to
  close the vm window if Parallels Desktop is open:

```yaml
- name: parallels-vm
  driver:
    provider: parallels
    box: parallels/centos-65
    customize:
      on_window_close: keep-running
```

converts to:

```ruby
  c.vm.provider :parallels do |p|
    p.customize ["set", :id, "--on-window-close", "keep-running"]
  end
```
…rantfile

Add support to customize Parallels Vagrantfile
sethvargo added a commit that referenced this pull request Nov 10, 2014
Add support to customize Parallels Vagrantfile
@sethvargo sethvargo merged commit ad4ab36 into test-kitchen:master Nov 10, 2014
@sethvargo
Copy link
Contributor

I'd really prefer if we didn't have these special cases, but there are already exemptions from other providers, so 👍

@legal90
Copy link
Contributor

legal90 commented Nov 28, 2014

@sethvargo Thanks for merging that! Could you release a new driver version, please?

@sethvargo
Copy link
Contributor

Nope, not ready yet

@legal90
Copy link
Contributor

legal90 commented Jan 28, 2015

Huh... It is sad that this changeset was not included to the ChefDK 0.3.6 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants