Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Support waiting for codes (Exit and HTTP) using integers besides the existing code matchers #2205

Closed
mdelapenya opened this issue Feb 8, 2024 · 2 comments
Closed

[Enhancement]: Support waiting for codes (Exit and HTTP) using integers besides the existing code matchers #2205

mdelapenya opened this issue Feb 8, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Want to contribute to testcontainers? Start from here

Comments

@mdelapenya
Copy link
Member

Proposal

The idea is to add som esugar on top of the existing code matchers:

Instead of this (example using the wait.ForExec strategy):

WithExitCodeMatcher(func(code int) bool {
	return code == 0
})

having this:

WithExitCode(0)

It will internally call the code matcher.
@mdelapenya mdelapenya added good first issue Want to contribute to testcontainers? Start from here enhancement New feature or request labels Feb 8, 2024
@bearrito bearrito mentioned this issue Mar 12, 2024
Merged
@bearrito
Copy link
Contributor

Could be closed.

@mdelapenya
Copy link
Member Author

Close as completed in #2342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Want to contribute to testcontainers? Start from here
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdelapenya @bearrito