-
-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Cannot import testcontainers-go without locking to specific versions of indirect dependencies #634
Comments
Hi @cyberbeast is this related to #629? We discussed there how to bypass it, sending PRs to update the docs and explaining why the replace directives. |
Did not mention in my previous comment, are the docs and the explanation in the release notes enough for you to consider this issue as closed? Other than that, please let us know if you have any suggestion on how to fix the transitive dependency with Docker Compose |
Reviewing #629 now |
@mdelapenya I reviewed #629, yes looks like it is related but the solution proposed there isn't sufficient for the errors I am seeing. I tried the suggested
resolves my
The only way I can resolve this is by using ALL of the directives from here |
I see that the release notes mention adding the single |
Indeed, you are right. I did a test in a sample Go repo and because one single test passed (debugged it with VSCode) I thought it was enough. Will immediately update the release notes, and the docs site. Would you mind reviewing the upcoming PR for that? |
Absolutely @mdelapenya :) |
Changelog and PR updated: #632 |
Hello, But now when I try to run a test attempting to use
|
@ouamer-dahmani can you share a repo or snippet with the failure, and what version of Go are you using? |
Hello, I do not have simplified reproduction and the code I am working on cannot be shared. I believe I am hitting a problem caused by another dependency needing a different version of the aws-sdk-go-v2 package. My question now would be why does testcontainers need the aws sdk? Or does it come from a transitive dependency? |
We are not using AWS deps directly, probably an indirect one |
Could we reopen this issue to track when we'll be able to remove these replace directives? It's all fine to say "we hope to be able to remove it in the next release" but this issue is still a problem until that is resolved, as far as I can tell. Thanks! |
Indeed, makes sense. I'm reopening it right now |
I faced an issue with another one external library Looks like the issue because of replacing docker/docker |
@ravilushqa can you share more on your environment: Go version, Docker version? We are testing the library against Go 1.18 and 1.x without errors on CI, so I'd like to identity your issues with a reproducible environment |
As a result of the new 0.18.0 release, which includes a bump in Docker Compose code that removes the replace directive for Docker, I'm going to close this issue. Please reopen if you consider it's not done or still have issues with it. Thanks for your patience |
Testcontainers version
0.16.0
Using the latest Testcontainers version?
Yes
Host OS
Macos
Host arch
x86
Go version
1.19
Docker version
Docker info
What happened?
Cannot import testcontainers-go without a bunch of indirect dependencies failing.
I have to add the following the replace directives to make it work.
If I don't lock these indirect dependencies to these versions (and use
latest
) things break.Relevant log output
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: