Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reliability of HostPortWaitStrategyTest #241

Merged
merged 2 commits into from
Nov 13, 2016

Conversation

rnorth
Copy link
Member

@rnorth rnorth commented Nov 13, 2016

After painstaking effort to determine the cause of these test failures, it seems that nc -lp 8080 inside the container was failing intermittently and exiting. This simple change works around this problem.

@bsideup
Copy link
Member

bsideup commented Nov 13, 2016

Maybe we should do the same in HttpWaitStrategyTest ?

@rnorth
Copy link
Member Author

rnorth commented Nov 13, 2016 via email

…ontainer-led test flapping (same as for HostPortWaitStrategyTest)
@rnorth rnorth merged commit 90cc31b into master Nov 13, 2016
@rnorth rnorth deleted the host-port-wait-test-stabilize branch November 13, 2016 10:32
@rnorth rnorth mentioned this pull request Nov 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants