Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoClassDefFoundError: com/google/common/io/Resources #398

Closed
rnorth opened this issue Jul 9, 2017 · 3 comments
Closed

NoClassDefFoundError: com/google/common/io/Resources #398

rnorth opened this issue Jul 9, 2017 · 3 comments
Labels
Milestone

Comments

@rnorth
Copy link
Member

rnorth commented Jul 9, 2017

This is occurring in the tests for the newly separated mariadb module, using v1.4.0 of Testcontainers as the parent version.

See https://travis-ci.org/testcontainers/testcontainers-java-module-mariadb#L847

I think we have an undeclared dependency on Guava inside ContainerDatabaseDriver:

                URL resource = Resources.getResource(initScriptPath);
                String sql = Resources.toString(resource, Charsets.UTF_8);

Since we're trying to get rid of Guava because of its implications for dependency clashes, I'd say we should replace this with a fairly trivial non-Guava implementation.

@rnorth
Copy link
Member Author

rnorth commented Jul 10, 2017

Just checked, the jdbc module has Guava as a provided dependency but it's no longer being shaded in, hence breakage.

@bsideup
Copy link
Member

bsideup commented Jul 10, 2017

@rnorth
Damn! I hate Maven >_<

Let's release it as 1.4.1 hotfix, will do the change

@bsideup bsideup added this to the 1.4.1 milestone Jul 10, 2017
@bsideup
Copy link
Member

bsideup commented Jul 10, 2017

Should be fixed in #399

@rnorth can you try it (with jitpack) in MariaDB module?

@bsideup bsideup closed this as completed Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants