Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make .standard_todo.yml narrow to migrate smoother #311

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

mtsmfm
Copy link
Contributor

@mtsmfm mtsmfm commented Jul 9, 2021

Currently, --generate-todo generates todo.yml which ignores all rules.

$ cat foo.rb
foo = 'foo'
$ standard --generate-todo
$ cat .standard_todo.yml
# Auto generated files with errors to ignore.
# Remove from this list as you refactor files.
---
ignore:
- foo.rb:

This patch makes todo.yml narrow.
It prevents increasing todos.

$ cat foo.rb
foo = 'foo'
$ standard --generate-todo
$ cat .standard_todo.yml
# Auto generated files with errors to ignore.
# Remove from this list as you refactor files.
---
ignore:
- foo.rb:
  - Lint/UselessAssignment
  - Style/StringLiterals

Currently, --generate-todo generates todo.yml which ignores all rules.

```
$ cat foo.rb
foo = 'foo'
$ standard --generate-todo
$ cat .standard_todo.yml
# Auto generated files with errors to ignore.
# Remove from this list as you refactor files.
---
ignore:
- foo.rb:
```

This patch makes todo.yml narrow.
It prevents increasing todos.

```
$ cat foo.rb
foo = 'foo'
$ standard --generate-todo
$ cat .standard_todo.yml
# Auto generated files with errors to ignore.
# Remove from this list as you refactor files.
---
ignore:
- foo.rb:
  - Lint/UselessAssignment
  - Style/StringLiterals
```
@searls
Copy link
Contributor

searls commented Jul 28, 2021

Sorry it took me so long to review this! I wanted to pull down the code myself to test it.

@searls searls merged commit d3af347 into standardrb:main Jul 28, 2021
@searls
Copy link
Contributor

searls commented Jul 28, 2021

Landed in 1.1.7

@mtsmfm mtsmfm deleted the improve-todo-gen branch July 28, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants