-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatibility with new testing-library/user-event release #190
Comments
Hi, thanks for opening this issue. The new I can also take a look at it, but it will take a few days. |
That was exactly what I needed. Thank you! Closing this issue, as I was able to determine it had nothing to do with any testing-library project. A 3rd party component (which uses setTimeout heavily), just happened to work because of the way userEvent.type had been implemented. I was able to use the config mechanism that you pointed out, to write my own wrapper to keep the 3rd party component happy (and even clean up some hacks I had put in my tests to accommodate that component). |
Is this something that we would also need to fix in this library? |
Lol. That is why I closed, reopened and again closed this issue... I was trying to decide the same thing. There may be folks that run into a similar problem, but I feel this is ultimately a user land issue, not something for the angular-testing-library. The 3rd party component (Syncfusion Angular Grid) receives the events from My "fix" was to use the On a related note, it would be great if angular-testing-library took a tail patch approach to |
The tests for my angular app make many calls to userEvent.type in testing-library/user-event.
With the new release of testing-library/user-event, these tests (which were passing), now break, and the cause seems to be that angular is no longer detecting changes triggered by typing.
This is not to surprising given the changes described in this user-event PR.
Indeed, rolling back to the previous version of userEvent results in successful tests again.
I'm happy to do more research/debugging, but need a little guidance...
It's not clear to me how the angular-testing-library has been detecting the changes triggered by the previous userEvent.type implementation. If I understood that mechanism better, it might help me provide more information about the current incompatibility.
Thoughts? Suggestions?
The text was updated successfully, but these errors were encountered: