fix(prefer-in-document): check that argument exists before accessing #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #242 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 558 560 +2
Branches 155 156 +1
=========================================
+ Hits 558 560 +2
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 3.9.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fixes a crash caught by #229 in
prefer-in-documentWhy:
It assumes that
expectcalls have an argument, which semantically they should but syntactically is not correct.How:
I've implemented a guard to ensure that the argument exists before trying to access any properties on it; have also added the test to the valid tests for every rule to ensure they can all handle the case.
Checklist: