Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed bug w/ toHaveAttribute("aria-check", "true") #50

Merged
merged 2 commits into from
Jun 11, 2020

Conversation

benmonro
Copy link
Member

@benmonro benmonro commented Jun 11, 2020

What:
Fixes #49

Why:
so it doesn't auto-fix incorrectly.

How:
add check for 'true'

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #50   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          129       129           
  Branches        18        18           
=========================================
  Hits           129       129           
Impacted Files Coverage Δ
src/createBannedAttributeRule.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64c9226...c216b74. Read the comment docs.

@benmonro benmonro changed the title fix: fixed bug w/ toHaveAttribute(aria-check true) fix: fixed bug w/ toHaveAttribute("aria-check", "true") Jun 11, 2020
@benmonro benmonro merged commit fef5a24 into master Jun 11, 2020
@benmonro benmonro deleted the feature/string-attribute-true branch June 11, 2020 16:45
@benmonro benmonro restored the feature/string-attribute-true branch June 11, 2020 16:45
@benmonro benmonro deleted the feature/string-attribute-true branch June 11, 2020 16:45
@benmonro
Copy link
Member Author

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prefer-checked fix is negating the resulting function when I believe it shouldn't be
1 participant