Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prefer-empty): Improve fixer for prefer-empty #73

Merged
merged 1 commit into from
Aug 9, 2020

Conversation

benmonro
Copy link
Member

@benmonro benmonro commented Aug 9, 2020

What:

handle non string/template literals in fixer for prefer empty

Why:

fixes: #72

How:
added check to skip fix if it isn't a non empty string / template literal
Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Aug 9, 2020

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #73   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          138       139    +1     
  Branches        21        21           
=========================================
+ Hits           138       139    +1     
Impacted Files Coverage Δ
src/rules/prefer-empty.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98ff818...7b966df. Read the comment docs.

@benmonro benmonro merged commit e3a12dc into master Aug 9, 2020
@benmonro benmonro deleted the bug/improve-fixer-for-prefer-empty branch August 9, 2020 19:39
@benmonro
Copy link
Member Author

benmonro commented Aug 9, 2020

🎉 This PR is included in version 3.1.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: handle template literals w/ no variables
1 participant